linux-kernel - Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show register contents

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1511871351.25007.460.camel@linux.intel.com>
Date:   Tue, 28 Nov 2017 14:15:51 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Mehta, Sohil" <sohil.mehta@...el.com>,
        "Kammela, Gayatri" <gayatri.kammela@...el.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "joro@...tes.org" <joro@...tes.org>
Cc:     "Yu, Fenghua" <fenghua.yu@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "jacob.jun.pan@...ux.intel.com" <jacob.jun.pan@...ux.intel.com>
Subject: Re: [PATCH v2 4/6] iommu/vt-d: Add debugfs extension to show
 register contents

On Tue, 2017-11-28 at 00:02 +0000, Mehta, Sohil wrote:
> On Mon, 2017-11-27 at 20:52 +0000, Kammela, Gayatri wrote:
> > 
> > > 
> > > From: Andy Shevchenko [mailto:andriy.shevchenko@...ux.intel.com]
> > > Sent: Wednesday, November 22, 2017 1:19 PM
> > >  
> > > Moreover, see the patch I have just sent [1] and use same
> > > DEFINE_SHOW_ATTRIBUTE() macro here. In that case we would easily
> > > move it
> > > to seq_file.h for everyone to use in the future.
> > 
> > That makes sense! I see your patch is not merged yet, so really
> > cannot reuse the same macro. I will have to redefine it.
> 
> Thanks Andy. That's a good suggestion. Are you planning to move the
> macro to seq_file.h soon? If so, should we include this marco in our
> patch after it has been merged?

Yes, I sent v2 [1] where it's moved to seq_file.h and asked Bluetooth maintainer to create an immutable branch for other subsystems.
So far the response is to roll back to v1 AFAIU.

[1]:  https://patchwork.ozlabs.org/cover/840899/

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy