linux-kernel - Re: [PATCH] bcache: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42696b58-1a5e-8a09-42ed-93ddb4621628@coly.li>
Date:   Tue, 28 Nov 2017 11:38:30 +0800
From:   Coly Li <i@...y.li>
To:     Vasyl Gomonovych <gomonovych@...il.com>
Cc:     kent.overstreet@...il.com, shli@...nel.org, mingo@...nel.org,
        axboe@...com, gregkh@...uxfoundation.org,
        kstewart@...uxfoundation.org, linux-bcache@...r.kernel.org,
        linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: Use PTR_ERR_OR_ZERO()

On 28/11/2017 7:05 AM, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/md/bcache/btree.c:1800:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>

Looks good to me. Reviewed-by: Coly Li <colyli@...e.de>

Thanks.

Coly Li

> ---
>  drivers/md/bcache/btree.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 658c54b3b07a..f43e49979cb2 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -1797,10 +1797,7 @@ static int bch_gc_thread(void *arg)
>  int bch_gc_thread_start(struct cache_set *c)
>  {
>  	c->gc_thread = kthread_run(bch_gc_thread, c, "bcache_gc");
> -	if (IS_ERR(c->gc_thread))
> -		return PTR_ERR(c->gc_thread);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(c->gc_thread);
>  }
>  
>  /* Initial partial gc */
>