linux-kernel - Re: [PATCH] bcache: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9b8fd4b-cb38-0bc9-cc27-0029cfe0a936@lyle.org>
Date:   Tue, 28 Nov 2017 08:18:57 -0800
From:   Michael Lyle <mlyle@...e.org>
To:     Vasyl Gomonovych <gomonovych@...il.com>, kent.overstreet@...il.com,
        shli@...nel.org, mingo@...nel.org, axboe@...com,
        gregkh@...uxfoundation.org, kstewart@...uxfoundation.org,
        linux-bcache@...r.kernel.org, linux-raid@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: Use PTR_ERR_OR_ZERO()

On 11/27/2017 03:05 PM, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/md/bcache/btree.c:1800:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>

lgtm.

Reviewed-by: Michael Lyle <mlyle@...e.org>

Will carry in my tree.