linux-kernel - Re: [PATCH] add missing "source" line for firmware subdirectory in drivers/Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f19cd91-997e-45ef-309d-2d1b83ae632e@infradead.org>
Date:   Tue, 28 Nov 2017 09:09:29 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Heiner Kallweit <hkallweit1@...il.com>,
        Sudeep Holla <sudeep.holla@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] add missing "source" line for firmware subdirectory in
 drivers/Kconfig

On 11/27/2017 11:12 PM, Heiner Kallweit wrote:
> I have a little bit of a hard time to find the right addressee for
> this patch because there is no maintainer entry for drivers/firmware.
> Can you apply the following through your tree?
> 
> Add missing entry for firmware subdirectory in drivers/Kconfig.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>]

Hi,
Why do you need this patch?  You should explain that in the (missing)
patch description.

I suppose that it could be done like this, but currently any $ARCH that
wants to use drivers/firmware/Kconfig does so in the arch/$ARCH/Kconfig file:

arch> grep firmware/Kconfig */Kconfig
arm/Kconfig:source "arch/arm/firmware/Kconfig"
arm/Kconfig:source "drivers/firmware/Kconfig"
arm64/Kconfig:source "drivers/firmware/Kconfig"
blackfin/Kconfig:source "drivers/firmware/Kconfig"
ia64/Kconfig:source "drivers/firmware/Kconfig"
mips/Kconfig:source "drivers/firmware/Kconfig"
x86/Kconfig:source "drivers/firmware/Kconfig"

so all of these would need to be removed.

> ---
>  drivers/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/Kconfig b/drivers/Kconfig
> index 152744c5e..a506867d9 100644
> --- a/drivers/Kconfig
> +++ b/drivers/Kconfig
> @@ -39,6 +39,8 @@ source "drivers/message/fusion/Kconfig"
>  
>  source "drivers/firewire/Kconfig"
>  
> +source "drivers/firmware/Kconfig"
> +
>  source "drivers/macintosh/Kconfig"
>  
>  source "drivers/net/Kconfig"
> 


-- 
~Randy