[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20171128084715.GF9862@localhost>
Date: Tue, 28 Nov 2017 09:47:15 +0100
From: Johan Hovold <johan@...nel.org>
To: Gimcuan Hui <gimcuan@...il.com>
Cc: Johan Hovold <johan@...nel.org>, gregkh@...uxfoundation.org,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: Clean up the return values of read_reg and
write_reg
On Mon, Nov 27, 2017 at 03:36:51PM +0000, Gimcuan Hui wrote:
> write_reg returns 0 on success, we can make it more explicit by returning
> number 0 instead of result variable.
>
> read_reg should return 0 on success since this is a more common pattern.
>
> The user of read_reg has been clean-up and should be at the same commit.
>
> Signed-off-by: Gimcuan Hui <gimcuan@...il.com>
Thanks for the update. Now applied for -next with a slightly modified
summary:
USB: serial: ark3116: clean up return values of register accessors
Johan
Powered by blists - more mailing lists