linux-kernel - Re: [PATCH] USB: serial: Clean up the return values of read_reg and write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Nov 2017 11:25:50 +0000
From:   Gimcuan Hui <gimcuan@...il.com>
To:     Johan Hovold <johan@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: Clean up the return values of read_reg and write_reg

On 28 November 2017 at 08:47, Johan Hovold <johan@...nel.org> wrote:
> On Mon, Nov 27, 2017 at 03:36:51PM +0000, Gimcuan Hui wrote:
>> write_reg returns 0 on success, we can make it more explicit by returning
>> number 0 instead of result variable.
>>
>> read_reg should return 0 on success since this is a more common pattern.
>>
>> The user of read_reg has been clean-up and should be at the same commit.
>>
>> Signed-off-by: Gimcuan Hui <gimcuan@...il.com>
>
> Thanks for the update. Now applied for -next with a slightly modified
> summary:
>
>         USB: serial: ark3116: clean up return values of register accessors
>
> Johan

:)

gimcuan