linux-kernel - Re: general protection fault in af_alg_free_areq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171129195109.GB29498@gmail.com>
Date:   Wed, 29 Nov 2017 11:51:09 -0800
From:   Eric Biggers <ebiggers3@...il.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     syzbot 
        <bot+ff72ab869817b6ea60bc570f638ee030f4fc73e5@...kaller.appspotmail.com>,
        davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        Stephan Mueller <smueller@...onox.de>
Subject: Re: general protection fault in af_alg_free_areq_sgls

On Wed, Nov 29, 2017 at 04:23:53PM +1100, Herbert Xu wrote:
> On Tue, Nov 28, 2017 at 01:02:52AM -0800, Eric Biggers wrote:
> > 
> > >From 1a7a7f86f09c50652f1fff75b8d3a32712826b32 Mon Sep 17 00:00:00 2001
> > From: Eric Biggers <ebiggers@...gle.com>
> > Date: Tue, 28 Nov 2017 00:46:24 -0800
> > Subject: [PATCH] crypto: af_alg - fix NULL pointer dereference in
> >  af_alg_free_areq_sgls()
> > 
> > If allocating the ->tsgl member of 'struct af_alg_async_req' failed,
> > during cleanup we dereferenced the NULL ->tsgl pointer in
> > af_alg_free_areq_sgls(), because ->tsgl_entries was nonzero.
> > 
> > Fix it by only freeing the ->tsgl list if it is non-NULL.
> > 
> > This affected both algif_skcipher and algif_aead.
> > 
> > Fixes: e870456d8e7c ("crypto: algif_skcipher - overhaul memory management")
> > Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management")
> > Reported-by: syzbot <syzkaller@...glegroups.com>
> > Cc: <stable@...r.kernel.org> # v4.14+
> > Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> 
> Patch applied.  Thanks.

Herbert, if it's not too late can you fix the subject?  It got split into two
lines:

commit 887207ed9e5812ed9239b6d07185a2d35dda91db
Author: Eric Biggers <ebiggers@...gle.com>
Date:   Tue Nov 28 00:46:24 2017 -0800

    crypto: af_alg - fix NULL pointer dereference in
    
     af_alg_free_areq_sgls()
    
    If allocating the ->tsgl member of 'struct af_alg_async_req' failed,
    during cleanup we dereferenced the NULL ->tsgl pointer in
    af_alg_free_areq_sgls(), because ->tsgl_entries was nonzero.
    
    Fix it by only freeing the ->tsgl list if it is non-NULL.
    
    This affected both algif_skcipher and algif_aead.
    
    Fixes: e870456d8e7c ("crypto: algif_skcipher - overhaul memory management")
    Fixes: d887c52d6ae4 ("crypto: algif_aead - overhaul memory management")
    Reported-by: syzbot <syzkaller@...glegroups.com>
    Cc: <stable@...r.kernel.org> # v4.14+
    Signed-off-by: Eric Biggers <ebiggers@...gle.com>
    Reviewed-by: Stephan Mueller <smueller@...onox.de>
    Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>