linux-kernel - Re: [PATCH] drm/tegra: gem: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eee5b3cd-b3c7-b59c-3899-307363a90e56@kapsi.fi>
Date:   Wed, 29 Nov 2017 11:12:37 +0200
From:   Mikko Perttunen <cyndis@...si.fi>
To:     Vasyl Gomonovych <gomonovych@...il.com>, thierry.reding@...il.com,
        airlied@...ux.ie, jonathanh@...dia.com,
        dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tegra: gem: Use PTR_ERR_OR_ZERO()

On 29.11.2017 00:18, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/gpu/drm/tegra/gem.c:420:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@...il.com>
> ---
>  drivers/gpu/drm/tegra/gem.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
> index ab1e53d434e8..a40148cd0957 100644
> --- a/drivers/gpu/drm/tegra/gem.c
> +++ b/drivers/gpu/drm/tegra/gem.c
> @@ -417,10 +417,8 @@ int tegra_bo_dumb_create(struct drm_file *file, struct drm_device *drm,
>
>  	bo = tegra_bo_create_with_handle(file, drm, args->size, 0,
>  					 &args->handle);
> -	if (IS_ERR(bo))
> -		return PTR_ERR(bo);
>
> -	return 0;
> +	return PTR_ERR_OR_ZERO(bo);

This is semantically less clear - the current code clearly has error and 
success paths while the changed code doesn't. Same for the other patch.

Cheers,
Mikko

>  }
>
>  static int tegra_bo_fault(struct vm_fault *vmf)
>