linux-kernel - Re: [PATCH] crypto: AF_ALG - wait for data at beginning of recvmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2780580.3j7i2QamZF@tauon.chronox.de>
Date:   Wed, 29 Nov 2017 11:28:43 +0100
From:   Stephan Mueller <smueller@...onox.de>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Eric Biggers <ebiggers3@...il.com>,
        syzbot 
        <bot+3401d9494b9380f7244bcc7fec49680878fccba6@...kaller.appspotmail.com>,
        davem@...emloft.net, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] crypto: AF_ALG - wait for data at beginning of recvmsg

Am Mittwoch, 29. November 2017, 11:22:34 CET schrieb Herbert Xu:

Hi Herbert,

> On Wed, Nov 29, 2017 at 11:17:26AM +0100, Stephan Müller wrote:
> > @@ -111,6 +111,12 @@ static int _aead_recvmsg(struct socket *sock, struct
> > msghdr *msg,> 
> >  	size_t usedpages = 0;		/* [in]  RX bufs to be used from user */
> >  	size_t processed = 0;		/* [in]  TX bufs to be consumed */
> > 
> > +	if (ctx->more) {
> > +		err = af_alg_wait_for_data(sk, flags);
> > +		if (err)
> > +			return err;
> > +	}
> 
> So what happens when sendmsg hasn't been called at all? In that
> case ctx->more would be zero, and we would skip the wait right?

Right, but wouldn't that be the correct order of operation? If somebody does 
not call sendmsg, he simply did not send any data. And that is yet a proper 
operation (for encryption) as it obtains the tag for the "null" data.

In case we have decryption and yet we received "null" data (e.g. sendmsg was 
not called) which implies the kernel received too little data (decryption at 
least requires the tag), aead_sufficient_data will return the error.

Ciao
Stephan