linux-kernel - Re: [PATCH] trace/xdp: fix compile warning: ‘struct bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171129071611.1dcabe5c@gandalf.local.home>
Date:   Wed, 29 Nov 2017 07:16:11 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Xie XiuQi <xiexiuqi@...wei.com>
Cc:     <mingo@...hat.com>, <davem@...emloft.net>, <brouer@...hat.com>,
        <daniel@...earbox.net>, <ast@...nel.org>,
        <kstewart@...uxfoundation.org>, <gregkh@...uxfoundation.org>,
        <john.fastabend@...il.com>, <linux-kernel@...r.kernel.org>,
        <huangdaode@...ilicon.com>, Hanjun Guo <guohanjun@...wei.com>
Subject: Re: [PATCH] trace/xdp: fix compile warning: ‘struct bpf_map’ declared inside parameter list

On Wed, 29 Nov 2017 16:35:01 +0800
Xie XiuQi <xiexiuqi@...wei.com> wrote:

> We meet this compile warning, which caused by missing bpf.h in xdp.h.
> 
> In file included from ./include/trace/events/xdp.h:10:0,
>                  from ./include/linux/bpf_trace.h:6,
>                  from drivers/net/ethernet/intel/i40e/i40e_txrx.c:29:
> ./include/trace/events/xdp.h:93:17: warning: ‘struct bpf_map’ declared inside parameter list will not be visible outside of this definition or declaration
>     const struct bpf_map *map, u32 map_index),
>
> Reported-by: Huang Daode <huangdaode@...ilicon.com>
> Cc: Hanjun Guo <guohanjun@...wei.com>
> Signed-off-by: Xie XiuQi <xiexiuqi@...wei.com>
> ---
>  include/trace/events/xdp.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
> index 4cd0f05..8989a92 100644
> --- a/include/trace/events/xdp.h
> +++ b/include/trace/events/xdp.h
> @@ -8,6 +8,7 @@
>  #include <linux/netdevice.h>
>  #include <linux/filter.h>
>  #include <linux/tracepoint.h>
> +#include <linux/bpf.h>

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

>  
>  #define __XDP_ACT_MAP(FN)	\
>  	FN(ABORTED)		\