linux-kernel - Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBS3CDfEvp9NK7GuvXfrU1a0BqVVVxmBaCzfXT=gNOpQcw@mail.gmail.com>
Date:   Wed, 29 Nov 2017 05:02:15 -0800
From:   Stephane Eranian <eranian@...gle.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ben Gainey <ben.gainey@....com>,
        Kim Phillips <kim.phillips@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Darren Hart <dvhart@...radead.org>,
        Colin Ian King <colin.king@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information
 for inlined code

On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
>
> Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu:
> > From: Ben Gainey <ben.gainey@....com>
> > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t code, const char *file,
> >               return -1;
> >       }
> >
> > -     flen = strlen(file) + 1;
> > +     for (i = 0; i < nr_lines; ++i) {
> > +         flen += strlen(file_names[i]) + 1;
> > +     }
>
>
> Please follow the coding standard used in this file and in tools/perf,
> which is the kernel one.
>
> Thanks for providing instructions on how to reproduce the problem!
>
> Stephane, can you please Ack this?
>
Trying to test this but do not see the source code from example, yet.

>
> - Arnaldo