linux-kernel - Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information for inlined code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Nov 2017 16:27:37 +0000
From:   Ben Gainey <Ben.Gainey@....com>
To:     "eranian@...gle.com" <eranian@...gle.com>,
        "acme@...nel.org" <acme@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "jolsa@...hat.com" <jolsa@...hat.com>,
        "colin.king@...onical.com" <colin.king@...onical.com>,
        Kim Phillips <Kim.Phillips@....com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        "namhyung@...nel.org" <namhyung@...nel.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>
Subject: Re: [PATCH 3/3] tools/perf/jvmti: generate correct debug information
 for inlined code

On Wed, 2017-11-29 at 05:02 -0800, Stephane Eranian wrote:
> On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo
> <acme@...nel.org> wrote:
> >
> > Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu:
> > > From: Ben Gainey <ben.gainey@....com>
> > > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t
> > > code, const char *file,
> > >               return -1;
> > >       }
> > >
> > > -     flen = strlen(file) + 1;
> > > +     for (i = 0; i < nr_lines; ++i) {
> > > +         flen += strlen(file_names[i]) + 1;
> > > +     }
> >
> >
> > Please follow the coding standard used in this file and in
> > tools/perf,
> > which is the kernel one.
> >
> > Thanks for providing instructions on how to reproduce the problem!
> >
> > Stephane, can you please Ack this?
> >
>
> Trying to test this but do not see the source code from example, yet.

Hi Stephane, sorry can you please clarify; were you expecting to see
source embedded in the output from perf annotate, or are just missing
the source for the reproducer, or something else?

If it is the former, then there is no source in the output, only line
numbers and filenames, but this is not a regression (that I am aware
of) as it was not there before the patch either.


>
> >
> > - Arnaldo
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.