linux-kernel - Re: [PATCH v3 4/5] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ASDXOua6MVM86bfaN-5zrjjMXG5F2sRwNLKoG1a+7agZTaKg@mail.gmail.com>
Date:   Wed, 29 Nov 2017 09:09:29 -0800
From:   Brian Norris <briannorris@...omium.org>
To:     Sean Paul <seanpaul@...omium.org>
Cc:     Matthias Kaehlcke <mka@...omium.org>,
        Nickey Yang <nickey.yang@...k-chips.com>,
        Rob Herring <robh+dt@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Mark Rutland <mark.rutland@....com>, airlied@...ux.ie,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Kristian Kristensen <hoegsberg@...il.com>,
        Archit Taneja <architt@...eaurora.org>,
        Philippe CORNU <philippe.cornu@...com>, yannick.fertre@...com,
        hl <hl@...k-chips.com>, Chris Zhong <zyw@...k-chips.com>,
        xbl@...k-chips.com, hjc@...k-chips.com
Subject: Re: [PATCH v3 4/5] drm/rockchip: Add ROCKCHIP DW MIPI DSI controller driver

On Tue, Nov 28, 2017 at 6:02 PM, Sean Paul <seanpaul@...omium.org> wrote:
> On Tue, Nov 28, 2017 at 02:55:41PM -0800, Brian Norris wrote:
>> On Tue, Nov 28, 2017 at 12:48:43PM -0800, Matthias Kaehlcke wrote:
>> > El Tue, Nov 28, 2017 at 07:20:05PM +0800 Nickey Yang ha dit:
>> >
>> > > Add the ROCKCHIP DSI controller driver that uses the Synopsys DesignWare
>> > > MIPI DSI host controller bridge.
>> > >
>> > > v2:
>> > >    add err_pllref, remove unnecessary encoder.enable & disable
>> > >    correct spelling mistakes
>> > > v3:
>> > >    call dw_mipi_dsi_unbind() in dw_mipi_dsi_rockchip_unbind()
>> > >    fix typo, use of_device_get_match_data(),
>> > >    change some ‘bind()’ logic into 'probe()'
>> > >    add 'dev_set_drvdata()'
>>
>> I believe the changelog normally goes below the "---", so it gets
>> dropped when a maintainer applies a final version.
>>
>
> We're kind of different in drm land. Some prefer to keep the changelog above the
> fold and attribute the changes to reviewers so they get recognition for their
> efforts.

Ah, now I remember reading that somewhere. Seems nice, I suppose. (And
hey, git logs are cheap.) I guess my "I don't review DRM patches much"
status is showing :)

> At any rate, I'm just happy to see changelogs.

Yep :)

Brian