linux-kernel - Re: [PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171129183732.GA74243@google.com>
Date:   Wed, 29 Nov 2017 10:37:33 -0800
From:   Brian Norris <briannorris@...omium.org>
To:     Nickey Yang <nickey.yang@...k-chips.com>
Cc:     robh+dt@...nel.org, heiko@...ech.de, mark.rutland@....com,
        airlied@...ux.ie, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        linux-rockchip@...ts.infradead.org, seanpaul@...omium.org,
        mka@...omium.org, hoegsberg@...il.com, architt@...eaurora.org,
        philippe.cornu@...com, yannick.fertre@...com, hl@...k-chips.com,
        zyw@...k-chips.com, xbl@...k-chips.com,
        Doug Anderson <dianders@...omium.org>
Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: update mipi node for RK3399

+ Doug, since he was asking these things elsewhere

On Tue, Nov 28, 2017 at 07:20:06PM +0800, Nickey Yang wrote:
> This patch update mipi node for RK3399 DSI controller
> based on the Synopsys DesignWare MIPI DSI host controller.
> 
> Signed-off-by: Nickey Yang <nickey.yang@...k-chips.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index d340b58a..0ac67a9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,9 +1652,11 @@
>  		status = "disabled";
>  
>  		ports {
> -			mipi_in: port {
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;

^^ It's good to add these here, since child nodes are going to have unit
addresses.

> +
> +			mipi_in: port@0 {
> +				reg = <0>;

^^ But you're removing the #{address,size}-cells from the port, while
still using unit addresses on its subnodes (the endpoint@... nodes). You
should keep *both*, since both the 'ports' node and the 'port@0' node
will have children with addresses.

Brian

>  
>  				mipi_in_vopb: endpoint@0 {
>  					reg = <0>;
> -- 
> 1.9.1
>