linux-kernel - Re: [PATCH v3 3/5] dt-bindings: display: rockchip: update DSI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171130165823.GA140320@google.com>
Date:   Thu, 30 Nov 2017 08:58:24 -0800
From:   Brian Norris <briannorris@...omium.org>
To:     Nickey Yang <nickey.yang@...k-chips.com>
Cc:     robh+dt@...nel.org, heiko@...ech.de, mark.rutland@....com,
        airlied@...ux.ie, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        linux-rockchip@...ts.infradead.org, seanpaul@...omium.org,
        mka@...omium.org, hoegsberg@...il.com, architt@...eaurora.org,
        philippe.cornu@...com, yannick.fertre@...com, hl@...k-chips.com,
        zyw@...k-chips.com, xbl@...k-chips.com
Subject: Re: [PATCH v3 3/5] dt-bindings: display: rockchip: update DSI
 controller

On Tue, Nov 28, 2017 at 07:20:04PM +0800, Nickey Yang wrote:
> This patch update documentation of device tree bindings for the rockchip
> DSI controller based on the Synopsys DesignWare MIPI DSI host controller.

It might help to describe why you're doing this. Just saying "update" is
pretty vague. In this case, it's something like "describe panel/port
links, including unit addresses".

> 
> Signed-off-by: Nickey Yang <nickey.yang@...k-chips.com>
> ---
>  .../display/rockchip/dw_mipi_dsi_rockchip.txt      | 23 ++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> index 6bb59ab..336909d 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt
> @@ -14,6 +14,8 @@ Required properties:
>  - rockchip,grf: this soc should set GRF regs to mux vopl/vopb.
>  - ports: contain a port node with endpoint definitions as defined in [2].
>    For vopb,set the reg = <0> and set the reg = <1> for vopl.
> +- video port 0 for the VOP input, the remote endpoint maybe vopb or vopl
> +- video port 1 for either a panel or subsequent encoder
>  
>  Optional properties:
>  - power-domains: a phandle to mipi dsi power domain node.
> @@ -40,11 +42,10 @@ Example:
>  		ports {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
> -			reg = <1>;
>  
> -			mipi_in: port {
> -				#address-cells = <1>;
> -				#size-cells = <0>;

^^ You're removing #{address,size}-cells here, but then port@0 will
still have subnodes that have 'reg' properties, so I think you need to
keep the -cells properties.

Brian

> +			mipi_in: port@0 {
> +				reg = <0>;
> +
>  				mipi_in_vopb: endpoint@0 {
>  					reg = <0>;
>  					remote-endpoint = <&vopb_out_mipi>;
> @@ -54,6 +55,14 @@ Example:
>  					remote-endpoint = <&vopl_out_mipi>;
>  				};
>  			};
> +
> +			mipi_out: port@1 {
> +				reg = <1>;
> +
> +				mipi_out_panel: endpoint {
> +					remote-endpoint = <&panel_in_mipi>;
> +				};
> +			};
>  		};
>  
>  		panel {
> @@ -64,5 +73,11 @@ Example:
>  			pinctrl-names = "default";
>  			pinctrl-0 = <&lcd_en>;
>  			backlight = <&backlight>;
> +
> +			port {
> +				panel_in_mipi: endpoint {
> +					remote-endpoint = <&mipi_out_panel>;
> +				};
> +			};
>  		};
>  	};
> -- 
> 1.9.1
>