linux-kernel - Re: [PATCH] leds: pm8058: Make ledtype pointer sized type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <661e011e-d7d2-4947-6648-8e76e3426aaa@gmail.com>
Date:   Thu, 30 Nov 2017 23:02:51 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Lee Jones <lee.jones@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Richard Purdie <rpurdie@...ys.net>, Pavel Machek <pavel@....cz>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH] leds: pm8058: Make ledtype pointer sized type

On 11/30/2017 09:31 AM, Lee Jones wrote:
> On Thu, 30 Nov 2017, Lee Jones wrote:
> 
>> On Wed, 29 Nov 2017, Bjorn Andersson wrote:
>>
>>> The pointer returned by of_device_get_match_data() doesn't have the same
>>> size as u32 on 64-bit architectures, causing issues when compile testing
>>> the driver on such platform. Make ledtype unsigned long instead, to
>>> solve this problem.
>>>
>>> Fixes: 7f866986e705 ("leds: add PM8058 LEDs driver")
>>> Cc: Linus Walleij <linus.walleij@...aro.org>
>>> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>>> ---
>>>  drivers/leds/leds-pm8058.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Hi Bjorn,
>>
>> (Nice to see you) :)
>>
>> I'm going to apply this *before* Linus' fix.
>>
>> Applied, thanks.
> 
> After I rx an Ack from Richard, Jacek or Pavel of course. :)
> 
> Will send a pull-request.

Huh? This is for LED subsystem AFAICS.

-- 
Best regards,
Jacek Anaszewski