linux-kernel - Re: [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <923625e8-f071-c9f6-a3e2-c16480d4aea6@deltatee.com>
Date:   Thu, 30 Nov 2017 15:04:29 -0700
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Serge Semin <fancer.lancer@...il.com>, jdmason@...zu.us,
        dave.jiang@...el.com, Allen.Hubbe@....com,
        Shyam-sundar.S-k@....com, Xiangliang.Yu@....com
Cc:     Sergey.Semin@...latforms.ru, linux-ntb@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/08] NTB: ntb_test: Safely use paths with whitespace

Hey,

I took a cursory look at this series and it largely looks good to me. 
Nice work. If I have time in the next couple days I'll do a more 
thorough review. However, does the series not depend on changes to 
ntb_tool? It would have been good to include a cover letter describing 
the intention/plan.

On 30/11/17 02:42 PM, Serge Semin wrote:
> If some of variables like LOC/REM or LOCAL_*/REMOTE_* got
> whitespaces, the script may fail with syntax error.
> 
> Signed-off-by: Serge Semin <fancer.lancer@...il.com>

Seeing this is a bug fix I Ack Patch 1 and suggest it get merged ahead 
of the series.

Acked-by: Logan Gunthorpe <logang@...tatee.com>
Fixes: a9c59ef77458 ("ntb_test: Add a selftest script for the NTB 
subsystem")

Thanks for the fix.

Logan