linux-kernel - Re: [PATCH] ASoC: tfa9879: Export OF device ID as module alias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e143d60a-de5f-7d42-1359-a3c0e2e19929@axentia.se>
Date:   Thu, 30 Nov 2017 19:56:54 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     Fabio Estevam <fabio.estevam@....com>,
        Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] ASoC: tfa9879: Export OF device ID as module alias

On 2017-11-30 18:56, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.

Looks ok to me,

Reviewed-by: Peter Rosin <peda@...ntia.se>

Cheers,
Peter

> Before this patch:
> 
> $ modinfo sound/soc/codecs/snd-soc-tfa9879.ko  | grep alias
> alias:          i2c:tfa9879
> 
> After this patch:
> 
> $ modinfo sound/soc/codecs/snd-soc-tfa9879.ko  | grep alias
> alias:          i2c:tfa9879
> alias:          of:N*T*Cnxp,tfa9879C*
> alias:          of:N*T*Cnxp,tfa9879
> 
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> 
> ---
> 
>  sound/soc/codecs/tfa9879.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c
> index f8dd67ca0744..e7ca764b5729 100644
> --- a/sound/soc/codecs/tfa9879.c
> +++ b/sound/soc/codecs/tfa9879.c
> @@ -316,6 +316,7 @@ static const struct of_device_id tfa9879_of_match[] = {
>  	{ .compatible = "nxp,tfa9879", },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(of, tfa9879_of_match);
>  
>  static struct i2c_driver tfa9879_i2c_driver = {
>  	.driver = {
>