linux-kernel - Re: [PATCH] bus: simple-pm-bus: convert bool SIMPLE_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171201070232.v4uilgo5cydaoyqa@verge.net.au>
Date:   Fri, 1 Dec 2017 08:02:33 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-pm@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Kevin Hilman <khilman@...aro.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] bus: simple-pm-bus: convert bool SIMPLE_PM_BUS to
 tristate

On Thu, Nov 30, 2017 at 12:57:00PM +0100, Geert Uytterhoeven wrote:
> From: Paul Gortmaker <paul.gortmaker@...driver.com>
> 
> The Kconfig currently controlling compilation of this code is:
> 
> config SIMPLE_PM_BUS
>         bool "Simple Power-Managed Bus Driver"
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> In removing the orphaned modular support in a previous patch set,
> Geert indicated he'd rather see this code converted to tristate.
> 
> I normally don't do that because it extends functionality that I
> can't easily run time test or even know if the use case makes sense,
> but since in this case the author has nominated it as such, we do
> the conversion here.
> 
> Note that doesn't change the lack of run time testing ; this change
> is only tested for sucessful compile and modpost.
> 
> [geert: Ethernet is probed successfully on sh73a0/kzm9g after
>         insmodding simple-pm-bus.ko]
> 
> Cc: Kevin Hilman <khilman@...aro.org>
> Cc: Simon Horman <horms+renesas@...ge.net.au>
> Cc: linux-arm-kernel@...ts.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Acked-by: Simon Horman <horms+renesas@...ge.net.au>

> ---
>  drivers/bus/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index dc7b3c7b7d42fd09..57e011d36a79fce3 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -120,7 +120,7 @@ config QCOM_EBI2
>  	  SRAM, ethernet adapters, FPGAs and LCD displays.
>  
>  config SIMPLE_PM_BUS
> -	bool "Simple Power-Managed Bus Driver"
> +	tristate "Simple Power-Managed Bus Driver"
>  	depends on OF && PM
>  	help
>  	  Driver for transparent busses that don't need a real driver, but
> -- 
> 2.7.4
>