linux-kernel - Re: [PATCH] bus: simple-pm-bus: convert bool SIMPLE_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3708548.hFOf0HkmBe@aspire.rjw.lan>
Date:   Sun, 17 Dec 2017 19:01:08 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Simon Horman <horms@...ge.net.au>,
        Geert Uytterhoeven <geert+renesas@...der.be>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-pm@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Kevin Hilman <khilman@...aro.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] bus: simple-pm-bus: convert bool SIMPLE_PM_BUS to tristate

On Friday, December 1, 2017 8:02:33 AM CET Simon Horman wrote:
> On Thu, Nov 30, 2017 at 12:57:00PM +0100, Geert Uytterhoeven wrote:
> > From: Paul Gortmaker <paul.gortmaker@...driver.com>
> > 
> > The Kconfig currently controlling compilation of this code is:
> > 
> > config SIMPLE_PM_BUS
> >         bool "Simple Power-Managed Bus Driver"
> > 
> > ...meaning that it currently is not being built as a module by anyone.
> > 
> > In removing the orphaned modular support in a previous patch set,
> > Geert indicated he'd rather see this code converted to tristate.
> > 
> > I normally don't do that because it extends functionality that I
> > can't easily run time test or even know if the use case makes sense,
> > but since in this case the author has nominated it as such, we do
> > the conversion here.
> > 
> > Note that doesn't change the lack of run time testing ; this change
> > is only tested for sucessful compile and modpost.
> > 
> > [geert: Ethernet is probed successfully on sh73a0/kzm9g after
> >         insmodding simple-pm-bus.ko]
> > 
> > Cc: Kevin Hilman <khilman@...aro.org>
> > Cc: Simon Horman <horms+renesas@...ge.net.au>
> > Cc: linux-arm-kernel@...ts.infradead.org
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> > Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> Acked-by: Simon Horman <horms+renesas@...ge.net.au>

Applied, thanks!