linux-kernel - Re: [PATCH] leds: pm8058: Make ledtype pointer sized type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171201002858.GD2808@amd>
Date:   Fri, 1 Dec 2017 01:28:58 +0100
From:   Pavel Machek <pavel@....cz>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Lee Jones <lee.jones@...aro.org>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH] leds: pm8058: Make ledtype pointer sized type

Hi!

> > > of_device_get_match_data will return PM8058_LED_TYPE_*
> > > which clearly is a led type identifier.
> > > 
> > > Thus unsigned long looks reasonable.  
> > 
> > Hmm. Ok. So u32 would actually make even more sense there (because
> > PM8058_LED_TYPE_* does not really need to be 64-bit), but it would
> > cause a warning.
> > 
> > I don't like this. This fix actually makes code waste memory and is
> > uglier.
> > 
> > ...but we get a warning fix. So I don't like the patch, but it is an
> > improvement...
> 
> I *think* you can get away with (u32)(unsigned long)ptr ...

Yes, that should work. It would actually be my preferred solution.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)