linux-kernel - RE: [PATCH 1/2] mtd: spi-nor: add a API to restore the addressing mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5PR0402MB2771FEA92608C8EAC270966B84390@AM5PR0402MB2771.eurprd04.prod.outlook.com>
Date:   Fri, 1 Dec 2017 10:06:22 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "boris.brezillon@...e-electrons.com" 
        <boris.brezillon@...e-electrons.com>,
        "marek.vasut@...il.com" <marek.vasut@...il.com>,
        "richard@....at" <richard@....at>
Subject: RE: [PATCH 1/2] mtd: spi-nor: add a API to restore the addressing
 mode

Hi Cyrille,

Thanks a lot for your comments!

> -----Original Message-----
> From: Cyrille Pitchen [mailto:cyrille.pitchen@...ev4u.fr]
> Sent: 2017年12月1日 16:53
> To: Z.q. Hou <zhiqiang.hou@....com>; linux-mtd@...ts.infradead.org;
> linux-kernel@...r.kernel.org; computersforpeace@...il.com;
> dwmw2@...radead.org; boris.brezillon@...e-electrons.com;
> marek.vasut@...il.com; richard@....at
> Subject: Re: [PATCH 1/2] mtd: spi-nor: add a API to restore the addressing
> mode
> 
> Hi Hou,
> 
> Le 24/11/2017 à 11:08, Zhiqiang Hou a écrit :
> > From: Hou Zhiqiang <Zhiqiang.Hou@....com>
> >
> > It's better to restore the addressing mode of the SPI flash whenever
> > remove the driver or reboot the system.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
> > ---
> >  drivers/mtd/spi-nor/spi-nor.c | 8 ++++++++
> >  include/linux/mtd/spi-nor.h   | 1 +
> >  2 files changed, 9 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c
> > b/drivers/mtd/spi-nor/spi-nor.c index bc266f70a15b..801cbe99b059
> > 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -2713,6 +2713,14 @@ static void spi_nor_resume(struct mtd_info
> *mtd)
> >  		dev_err(dev, "resume() failed\n");
> >  }
> >
> > +void spi_nor_restore_addr_mode(struct spi_nor *nor) {
> > +	if ((nor->addr_width == 4) &&
> > +	    (JEDEC_MFR(nor->info) != SNOR_MFR_SPANSION) &&
> > +	    !(nor->info->flags & SPI_NOR_4B_OPCODES))
> > +		set_4byte(nor, nor->info, 0);
> > +}
> + EXPORT_SYMBOL_GPL(spi_nor_restore_addr_mode);
> 
> Like for spi_nor_scan(), you would need to export the symbol for modules.

Yes, I will add this in next version.

> 
> > +
> >  int spi_nor_scan(struct spi_nor *nor, const char *name,
> >  		 const struct spi_nor_hwcaps *hwcaps)  { diff --git
> > a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h index
> > d0c66a0975cf..fe9357da2049 100644
> > --- a/include/linux/mtd/spi-nor.h
> > +++ b/include/linux/mtd/spi-nor.h
> > @@ -398,5 +398,6 @@ struct spi_nor_hwcaps {
> >   */
> >  int spi_nor_scan(struct spi_nor *nor, const char *name,
> >  		 const struct spi_nor_hwcaps *hwcaps);
> > +void spi_nor_restore_addr_mode(struct spi_nor *nor);
> >
> Please add the relevant kernel doc.

Yes, will add comments for this API in next version.

> 
> Best regards,
> 
> Cyrille
> 
> >  #endif
> >

Thanks,
Zhiqiang