linux-kernel - RE: [PATCH 2/2] mtd: m25p80: restore the addressing mode when stop using the flash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM5PR0402MB2771E30AB082C9AB415A55A784390@AM5PR0402MB2771.eurprd04.prod.outlook.com>
Date:   Fri, 1 Dec 2017 10:06:29 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "boris.brezillon@...e-electrons.com" 
        <boris.brezillon@...e-electrons.com>,
        "marek.vasut@...il.com" <marek.vasut@...il.com>,
        "richard@....at" <richard@....at>
Subject: RE: [PATCH 2/2] mtd: m25p80: restore the addressing mode when stop
 using the flash

Hi Cyrille,

Thanks for your comments!

> -----Original Message-----
> From: Cyrille Pitchen [mailto:cyrille.pitchen@...ev4u.fr]
> Sent: 2017年12月1日 16:58
> To: Z.q. Hou <zhiqiang.hou@....com>; linux-mtd@...ts.infradead.org;
> linux-kernel@...r.kernel.org; computersforpeace@...il.com;
> dwmw2@...radead.org; boris.brezillon@...e-electrons.com;
> marek.vasut@...il.com; richard@....at
> Subject: Re: [PATCH 2/2] mtd: m25p80: restore the addressing mode when
> stop using the flash
> 
> Hi Hou,
> 
> Le 24/11/2017 à 11:08, Zhiqiang Hou a écrit :
> > From: Hou Zhiqiang <Zhiqiang.Hou@....com>
> >
> > Add .shutdown function to restore the addressing mode in reboot
> > process, and add the same operation to the .remove function.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
> > ---
> >  drivers/mtd/devices/m25p80.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/mtd/devices/m25p80.c
> > b/drivers/mtd/devices/m25p80.c index dbe6a1de2bb8..867bd2d5a267
> 100644
> > --- a/drivers/mtd/devices/m25p80.c
> > +++ b/drivers/mtd/devices/m25p80.c
> > @@ -307,10 +307,17 @@ static int m25p_remove(struct spi_device *spi)
> > {
> >  	struct m25p	*flash = spi_get_drvdata(spi);
> >
> > +	spi_nor_restore_addr_mode(&flash->spi_nor);
> 
> maybe add a new line here.
> 
> Otherwise, this looks good :)

Yes, will add in next version, thanks a lot for the suggestion!


Thanks,
Zhiqiang