linux-kernel - Re: [PATCH] tools lib traceevent: fix an incorrect comparison with the literal "s64"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171130192115.03d93d38@gandalf.local.home>
Date:   Thu, 30 Nov 2017 19:21:15 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        "David S . Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools lib traceevent: fix an incorrect comparison with
 the literal "s64"


Arnaldo,

Can you take this in your tree. And mark it for stable. Thanks!

On Mon, 27 Nov 2017 16:19:09 +0000
Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> I believe the comparison of the string 'type' with the literal string
> "s64" is currently incorrect, it is missing a == 0 comparison as per
> the other comparisons.
> 
> Detected by cppcheck:
> tools/lib/traceevent/event-parse.c:2209: (warning) The comparison
> operator in 'strcmp(type,"s64") != 0' should maybe be '==' instead,
> currently the expression 'strcmp(type,"u64") == 0' is redundant.
> 
> Fixes: f7d82350e597 ("tools/events: Add files to create libtraceevent.a")

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve

> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  tools/lib/traceevent/event-parse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index 7ce724fc0544..82b6c64c5b39 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -2206,7 +2206,7 @@ eval_type_str(unsigned long long val, const char *type, int pointer)
>  		return val & 0xffffffff;
>  
>  	if (strcmp(type, "u64") == 0 ||
> -	    strcmp(type, "s64"))
> +	    strcmp(type, "s64") == 0)
>  		return val;
>  
>  	if (strcmp(type, "s8") == 0)