linux-kernel - Re: [PATCH 16/21] x86/entry/64: Use a per-CPU trampoline stack for IDT entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Dec 2017 13:59:52 -0800
From:   Andy Lutomirski <luto@...capital.net>
To:     Dave Hansen <dave.hansen@...ux.intel.com>
Cc:     Andy Lutomirski <luto@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Borislav Petkov <bp@...en8.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 16/21] x86/entry/64: Use a per-CPU trampoline stack for IDT entries



On Dec 1, 2017, at 1:21 PM, Dave Hansen <dave.hansen@...ux.intel.com> wrote:

>>>> [   30.811750] CR2: fffffffffdeb2f98 CR3: 0000000423fae001 CR4: 00000000001607e0
>>>> [   30.819712] Call Trace:
>>>> [   30.822442]  <SYSENTER>
>>>> [   30.825170]  trace_hardirqs_on_thunk+0x1c/0x1c
>>> ...
>>>> [   31.000571] R13: 0000000000000050 R14: 0000000000000076 R15: 00007f59f76f2d60
>>>> [   31.008533]  </SYSENTER>
>>> 
>>> Should we change that string to something more descriptive?
>> 
>> I suppose we could rename it to "ENTRY_TRAMPOLINE" or something like that.
> 
> The attached patch does just that.  Any objections?
> <SYSENTER-rename.patch>

I think that, if we do this, we should rename it in the code, too.  Calling it one thing in the oops and something else in the code is just going to add confusion.