linux-kernel - Re: [PATCH 16/21] x86/entry/64: Use a per-CPU trampoline stack for IDT entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171202064100.GA14200@la.guarana.org>
Date:   Sat, 2 Dec 2017 01:41:00 -0500
From:   Kevin Easton <kevin@...rana.org>
To:     Dave Hansen <dave.hansen@...ux.intel.com>
Cc:     Andy Lutomirski <luto@...nel.org>, Ingo Molnar <mingo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Borislav Petkov <bp@...en8.de>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 16/21] x86/entry/64: Use a per-CPU trampoline stack for
 IDT entries

> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> The "SYSENTER" stack is used for a lot more than SYSENTER now.
> Give it a better string to display in stack dumps.
> 
> We should probably cleanse the 64-bit code of the remaining
> "SYSENTER" nomenclature too at some point.
> 
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> ---
> 
>  b/arch//x86/kernel/dumpstack_64.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff -puN arch//x86/kernel/dumpstack_64.c~SYSENTER-rename arch//x86/kernel/dumpstack_64.c
> --- a/arch//x86/kernel/dumpstack_64.c~SYSENTER-rename	2017-12-01 12:43:16.768707737 -0800
> +++ b/arch//x86/kernel/dumpstack_64.c	2017-12-01 13:19:21.741702337 -0800
> @@ -37,8 +37,14 @@ const char *stack_type_name(enum stack_t
>  	if (type == STACK_TYPE_IRQ)
>  		return "IRQ";
>  
> -	if (type == STACK_TYPE_SYSENTER)
> -		return "SYSENTER";
> +	if (type == STACK_TYPE_SYSENTER) {
> +		/*
> +		 * On 64-bit, we have a generic entry stack that we
> +		 * use for all the kernel try points, including
> +		 * SYSENTER.

ITYM "kernel entry points".

    - Kevin