linux-kernel - Re: [PATCH] iio: accel: bmc150: Add OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171202120251.77ade310@archlinux>
Date:   Sat, 2 Dec 2017 12:02:51 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Javier Martinez Canillas <javierm@...hat.com>
Cc:     linux-kernel@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-iio@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Subject: Re: [PATCH] iio: accel: bmc150: Add OF device ID table

On Fri,  1 Dec 2017 12:10:58 +0100
Javier Martinez Canillas <javierm@...hat.com> wrote:

> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
> 
> The I2C device ID table entries have the .driver_data field set, but they
> are not used in the driver so weren't set in the OF device table entries.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Would be nice to do the spi counterpart at somepoint, but as this is
clearly an improvement on nothing I applied this one as step 1.

Good point about the data fields though - we should probably clean those
out as misleading.

Thanks,

Jonathan
> ---
> 
>  drivers/iio/accel/bmc150-accel-i2c.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/iio/accel/bmc150-accel-i2c.c b/drivers/iio/accel/bmc150-accel-i2c.c
> index f85014fbaa12..8ffc308d5fd0 100644
> --- a/drivers/iio/accel/bmc150-accel-i2c.c
> +++ b/drivers/iio/accel/bmc150-accel-i2c.c
> @@ -81,9 +81,21 @@ static const struct i2c_device_id bmc150_accel_id[] = {
>  
>  MODULE_DEVICE_TABLE(i2c, bmc150_accel_id);
>  
> +static const struct of_device_id bmc150_accel_of_match[] = {
> +	{ .compatible = "bosch,bmc150_accel" },
> +	{ .compatible = "bosch,bmi055_accel" },
> +	{ .compatible = "bosch,bma255" },
> +	{ .compatible = "bosch,bma250e" },
> +	{ .compatible = "bosch,bma222e" },
> +	{ .compatible = "bosch,bma280" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, bmc150_accel_of_match);
> +
>  static struct i2c_driver bmc150_accel_driver = {
>  	.driver = {
>  		.name	= "bmc150_accel_i2c",
> +		.of_match_table = bmc150_accel_of_match,
>  		.acpi_match_table = ACPI_PTR(bmc150_accel_acpi_match),
>  		.pm	= &bmc150_accel_pm_ops,
>  	},