linux-kernel - Re: [PATCH] gpio: gpio-stmpe: make various char arrays static const, shrinks object size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbsvC0ziDN=L5PA0u3S2wVoOHkcuqYWAZknsAvOLyXs3g@mail.gmail.com>
Date:   Sat, 2 Dec 2017 13:05:51 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     linux-gpio@...r.kernel.org, kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: gpio-stmpe: make various char arrays static const,
 shrinks object size

On Tue, Nov 28, 2017 at 7:23 PM, Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> Don't populate the read-only arrays edge_det_values, rise_values and
> fall_values on the stack but instead make them static and constify them.
> Makes the object code smaller by over 240 bytes:
>
> Before:
>    text    data     bss     dec     hex filename
>    9525    2520     192   12237    2fcd drivers/gpio/gpio-stmpe.o
>
> After:
>    text    data     bss     dec     hex filename
>    9025    2776     192   11993    2ed9 drivers/gpio/gpio-stmpe.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch applied.

Yours,
Linus Walleij