linux-kernel - Re: [PATCH] staging: pi433: Removed some obsolete or duplicated defines; moved two defines to better locations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <30f27e3f-bd83-f44b-f0b1-f3c97fa2373c@smarthome-wolf.de>
Date:   Sat, 2 Dec 2017 18:00:28 +0200
From:   Marcus Wolf <marcus.wolf@...rthome-wolf.de>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Marcus Wolf <linux@...f-entwicklungen.de>
Cc:     dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: Removed some obsolete or duplicated
 defines; moved two defines to better locations

Hi Greg,

for me the action was "clean up the defines in rf69.c". So for me it was 
fine, that two defines were moved and several other deleted at the same.

Is it ok for you, or should I split the patch belated?

Cheers,

Marcus

Am 02.12.2017 um 17:55 schrieb Greg KH:
> On Sat, Dec 02, 2017 at 05:14:08PM +0200, Marcus Wolf wrote:
>> The define FIFO_SIZE was moved to rf69_registers.h. Although it is not a register,
>> it is a value, that is given by hardware (like the registers).
>>
>> The define FIFO_THRESHOLD was moved to pi433_if.c, since it is a value, that is
>> freely choosen by the interface implementation. The better the response time of
>> the driver, the lower threshold can be set.
> 
> Shouldn't this be two separate patches?
> 
> Remember, each patch just does one thing.
> 
> thanks,
> 
> greg k-h
> 

-- 
Smarthome-Wolf UG (haftungsbeschränkt)
Helene-Lange-Weg 23
80637 München
Amtsgericht München, HRB 223529
Umastzsteuer-ID: DE304719911
Geschäftsführer: Marcus Wolf