lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sat, 2 Dec 2017 15:55:49 +0000
From:   Greg KH <>
To:     Marcus Wolf <>
Subject: Re: [PATCH] staging: pi433: Removed some obsolete or duplicated
 defines; moved two defines to better locations

On Sat, Dec 02, 2017 at 05:14:08PM +0200, Marcus Wolf wrote:
> The define FIFO_SIZE was moved to rf69_registers.h. Although it is not a register,
> it is a value, that is given by hardware (like the registers).
> The define FIFO_THRESHOLD was moved to pi433_if.c, since it is a value, that is
> freely choosen by the interface implementation. The better the response time of
> the driver, the lower threshold can be set.

Shouldn't this be two separate patches?

Remember, each patch just does one thing.


greg k-h

Powered by blists - more mailing lists