linux-kernel - Re: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5A230B9E.1080006@gmail.com>
Date:   Sun, 3 Dec 2017 01:52:54 +0530
From:   arvindY <arvind.yadav.cs@...il.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        wg@...ndegger.com, mkl@...gutronix.de, michal.simek@...inx.com,
        opendmb@...il.com, f.fainelli@...il.com, davem@...emloft.net,
        Vladislav.Zakharov@...opsys.com
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH 05/10] net: ethernet: i825xx: Fix platform_get_irq's error
 checking

Hi Sergei,

On Sunday 03 December 2017 01:38 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 12/02/2017 10:26 PM, Arvind Yadav wrote:
>
>> The platform_get_irq() function returns negative if an error occurs.
>> zero or positive number on success. platform_get_irq() error checking
>> for zero is not correct.
>
>    The why you consider returning 0 a sign of failure?
Here, Returning 0 is a problem. Because IRQ0 is always a problem.
This function is for getting an IRQ for a device. So we should check for
0 also.
>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
>> ---
>>   drivers/net/ethernet/i825xx/sni_82596.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/i825xx/sni_82596.c 
>> b/drivers/net/ethernet/i825xx/sni_82596.c
>> index b2c04a7..a6d56f5 100644
>> --- a/drivers/net/ethernet/i825xx/sni_82596.c
>> +++ b/drivers/net/ethernet/i825xx/sni_82596.c
>> @@ -120,9 +120,10 @@ static int sni_82596_probe(struct 
>> platform_device *dev)
>>       netdevice->dev_addr[5] = readb(eth_addr + 0x06);
>>       iounmap(eth_addr);
>>   -    if (!netdevice->irq) {
>> +    if (netdevice->irq <= 0) {
>>           printk(KERN_ERR "%s: IRQ not found for i82596 at 0x%lx\n",
>>               __FILE__, netdevice->base_addr);
>> +        retval = netdevice->irq ? netdevice->irq : -ENODEV;
>>           goto probe_failed;
>>       }
>
> MBR, Sergei
~arvind