linux-kernel - Re: [PATCH] KVM: x86: MMU: make array audit_point

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45047bd6-4a27-2c16-b00b-bb7911792b8f@redhat.com>
Date:   Mon, 4 Dec 2017 11:41:04 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Colin King <colin.king@...onical.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kvm@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: MMU: make array audit_point_name static

On 30.11.2017 13:04, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The array audit_point_name is local to the source and does not need to
> be in global scope, so make it static.
> 
> Cleans up sparse warning:
> arch/x86/kvm/mmu_audit.c:22:12: warning: symbol 'audit_point_name' was
> not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  arch/x86/kvm/mmu_audit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu_audit.c b/arch/x86/kvm/mmu_audit.c
> index d22ddbdf5e6e..1272861e77b9 100644
> --- a/arch/x86/kvm/mmu_audit.c
> +++ b/arch/x86/kvm/mmu_audit.c
> @@ -19,7 +19,7 @@
>  
>  #include <linux/ratelimit.h>
>  
> -char const *audit_point_name[] = {
> +static char const *audit_point_name[] = {
>  	"pre page fault",
>  	"post page fault",
>  	"pre pte write",
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 

Thanks,

David / dhildenb