linux-kernel - Re: [GIT PULL] hash addresses printed with %p

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1512354837.6321.41.camel@perches.com>
Date:   Sun, 03 Dec 2017 18:33:57 -0800
From:   Joe Perches <joe@...ches.com>
To:     Dave Young <dyoung@...hat.com>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        "Tobin C. Harding" <me@...in.cc>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>
Subject: Re: [GIT PULL] hash addresses printed with %p

On Mon, 2017-12-04 at 10:02 +0800, Dave Young wrote:
> I think 0400 is good enough for this issue.
> 
> Greg, would you like to agree add an extra macro like below?
[]
> -static struct map_attribute map_type_attr = __ATTR_RO(type);
> -static struct map_attribute map_phys_addr_attr   = __ATTR_RO(phys_addr);
> -static struct map_attribute map_virt_addr_attr  = __ATTR_RO(virt_addr);
> -static struct map_attribute map_num_pages_attr  = __ATTR_RO(num_pages);
> -static struct map_attribute map_attribute_attr  = __ATTR_RO(attribute);
> +static struct map_attribute map_type_attr = __ATTR_IRUSR(type);
> +static struct map_attribute map_phys_addr_attr   = __ATTR_IRUSR(phys_addr);
> +static struct map_attribute map_virt_addr_attr  = __ATTR_IRUSR(virt_addr);
> +static struct map_attribute map_num_pages_attr  = __ATTR_IRUSR(num_pages);
> +static struct map_attribute map_attribute_attr  = __ATTR_IRUSR(attribute);
>  
>  /*
>   * These are default attributes that are added for every memmap entry.
> --- linux-x86.orig/include/linux/sysfs.h
> +++ linux-x86/include/linux/sysfs.h
> @@ -112,6 +112,11 @@ struct attribute_group {
>  	.store	= _store,						\
>  }
>  
> +#define __ATTR_IRUSR(_name) {					

I'd much prefer __ATTR_0400(_name)