linux-kernel - Re: [PATCH] perf tools: set GUI mode after returning from perf_session_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171204162813.GI13698@kernel.org>
Date:   Mon, 4 Dec 2017 13:28:13 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     SeokHo Song <0xdevssh@...il.com>
Cc:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH] perf tools: set GUI mode after returning from
 perf_session__new()

Em Tue, Dec 05, 2017 at 01:11:49AM +0900, SeokHo Song escreveu:
> Hi Arnaldo,
> 
> 2017-12-05 0:45 GMT+09:00 Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>:
> > Em Tue, Dec 05, 2017 at 12:05:18AM +0900, Namhyung Kim escreveu:
> >> Hi SeokHo,
> >>
> >> On Sun, Dec 3, 2017 at 10:50 PM, Song Seok Ho <0xdevssh@...il.com> wrote:
> >> > If perf_session__new() returns NULL with use_browser set to 2 via --gtk option
> >> > previously, perf dies quietly without printing any errors.
> >> >
> >> > The reason behind this is that GTK is not yet initialized when the caller
> >> > inside perf_session__new() is trying to print error message to the screen.
> >> >
> >> > Reorder code to print the messages to stdio when GTK is not yet ready.
> >>
> >> I'm ok with this change, but it needs to consider other error messages too.
> >> There are more pr_err() calls between perf_session__new() and
> >> setup_browser(), so I think they have same problem.
> >
> > So I think I can apply this one, with Namhyung's acked-by and then Song
> > can continue with followup patches?
> >
> > - Arnaldo
> >
> 
> I've sent a follow-up patch with a new title "[PATCH v2] perf tools:
> set browser mode
> right before setup_browser()" with Namhyung's Acked-by added.
> 
> Addressing Namhyung's comment, I've moved the use_browser variable assignment
> code below when setup_browser() is called.
> 
> Please let me know if it deserves to be in a different place.

Ok, I've replaced the copy I had with this v2 one.

- Arnaldo