linux-kernel - Re: [PATCH tip/core/rcu 2/6] srcu: Change printk() %p to %pK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171204183127.GA7829@linux.vnet.ibm.com>
Date:   Mon, 4 Dec 2017 10:31:27 -0800
From:   "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:     Lai Jiangshan <jiangshanlai@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>, dipankar@...ibm.com,
        akpm@...ux-foundation.org,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Josh Triplett <josh@...htriplett.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        David Howells <dhowells@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Frédéric Weisbecker <fweisbec@...il.com>,
        oleg@...hat.com
Subject: Re: [PATCH tip/core/rcu 2/6] srcu: Change printk() %p to %pK

On Sat, Dec 02, 2017 at 09:27:46AM +0800, Lai Jiangshan wrote:
> On Sat, Dec 2, 2017 at 3:41 AM, Paul E. McKenney
> <paulmck@...ux.vnet.ibm.com> wrote:
> > This commit changes the %p printk() in rcutorture to %pK.  This could
> > be considered irrelevant, given that any user able to start rcutorture
> > could inflict far heavier damage on the system, but it doesn't hurt to
> > change it and doing so avoids script-generated noise.
> >
> > Reported-by: Tobin C. Harding <me@...in.cc>
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> 
> Reviewed-by: Lai Jiangshan <jiangshanlai@...il.com>

Applied, thank you for the review!

							Thanx, Paul

> > ---
> >  kernel/rcu/srcutree.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c
> > index d5cea81378cc..81f2eb78c504 100644
> > --- a/kernel/rcu/srcutree.c
> > +++ b/kernel/rcu/srcutree.c
> > @@ -386,7 +386,7 @@ void cleanup_srcu_struct(struct srcu_struct *sp)
> >                 flush_delayed_work(&per_cpu_ptr(sp->sda, cpu)->work);
> >         if (WARN_ON(rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)) != SRCU_STATE_IDLE) ||
> >             WARN_ON(srcu_readers_active(sp))) {
> > -               pr_info("cleanup_srcu_struct: Active srcu_struct %p state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)));
> > +               pr_info("cleanup_srcu_struct: Active srcu_struct %pK state: %d\n", sp, rcu_seq_state(READ_ONCE(sp->srcu_gp_seq)));
> >                 return; /* Caller forgot to stop doing call_srcu()? */
> >         }
> >         free_percpu(sp->sda);
> > --
> > 2.5.2
> >
>