linux-kernel - Re: [PATCH] misc: rtsx: make several functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171205083148.gtfc2ayn5kmmyok7@dell>
Date:   Tue, 5 Dec 2017 08:31:48 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Rui Feng <rui_feng@...lsil.com.cn>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] misc: rtsx: make several functions static

On Mon, 04 Dec 2017, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Several functions are local to the source and do not need to be in global
> scope, so make them static.
> 
> Cleans up sparse warnings:
> symbol 'rtsx_pm_power_saving' was not declared. Should it be static?
> symbol 'rtsx_set_l1off_sub_cfg_d0' was not declared. Should it be static?
> symbol 'rtsx_pm_full_on' was not declared. Should it be static?
> symbol 'rtsx_comm_set_ltr_latency' was not declared. Should it be static?
> symbol 'rtsx_pci_process_ocp' was not declared. Should it be static?
> symbol 'rtsx_pci_process_ocp_interrupt' was not declared. Should it be
> static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/misc/cardreader/rtsx_pcr.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog