linux-kernel - Re: [PATCH][next] misc: rtsx: rts5260: make several functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171205083211.nhpsmhnati6blynz@dell>
Date:   Tue, 5 Dec 2017 08:32:11 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Daniel Bristot de Oliveira <bristot@...hat.com>,
        Rui Feng <rui_feng@...lsil.com.cn>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] misc: rtsx: rts5260: make several functions static

On Mon, 04 Dec 2017, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> Several functios are local to the source and do not need to be in global
> scope, so make them static.
> 
> Cleans up sparse warnings:
> symbol 'rts5260_get_ocpstat' was not declared. Should it be static?
> symbol 'rts5260_get_ocpstat2' was not declared. Should it be static?
> symbol 'rts5260_clear_ocpstat' was not declared. Should it be static?
> symbol 'rts5260_process_ocp' was not declared. Should it be static?
> symbol 'rts5260_init_hw' was not declared. Should it be static?
> symbol 'rts5260_set_aspm' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/misc/cardreader/rts5260.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Acked-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog