linux-kernel - Re: [PATCH] scripts/faddr2line: fix CROSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3875933.96IucGWEYa@blindfold>
Date:   Wed, 06 Dec 2017 20:16:26 +0100
From:   Richard Weinberger <richard@....at>
To:     "Liu, Changcheng" <changcheng.liu@...el.com>,
        linux-kernel@...r.kernel.org
Cc:     tglx@...utronix.de, gregkh@...uxfoundation.org,
        pombredanne@...b.com, neilb@...e.com, akpm@...ux-foundation.org
Subject: Re: [PATCH] scripts/faddr2line: fix CROSS_COMPILE unset error

Am Mittwoch, 6. Dezember 2017, 02:30:22 CET schrieb Liu, Changcheng:
> faddr2line hit var unbound error When CROSS_COMPILE
> isn't set since nounset option is set in bash script.
> 
> Signed-off-by: Liu Changcheng <changcheng.liu@...el.com>
> Reported-by: Richard Weinberger <richard.weinberger@...il.com>
> 
> diff --git a/scripts/faddr2line b/scripts/faddr2line
> index 39e07d8..7721d5b 100755
> --- a/scripts/faddr2line
> +++ b/scripts/faddr2line
> @@ -44,10 +44,10 @@
>  set -o errexit
>  set -o nounset
> 
> -READELF="${CROSS_COMPILE}readelf"
> -ADDR2LINE="${CROSS_COMPILE}addr2line"
> -SIZE="${CROSS_COMPILE}size"
> -NM="${CROSS_COMPILE}nm"
> +READELF="${CROSS_COMPILE:-}readelf"
> +ADDR2LINE="${CROSS_COMPILE:-}addr2line"
> +SIZE="${CROSS_COMPILE:-}size"
> +NM="${CROSS_COMPILE:-}nm"
> 
>  command -v awk >/dev/null 2>&1 || die "awk isn't installed"
>  command -v ${READELF} >/dev/null 2>&1 || die "readelf isn't installed"

Fixes: 95a879825419 ("scripts/faddr2line: extend usage on generic arch")
Reviewed-by: Richard Weinberger <richard@....at>

Thanks,
//richard