lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20171206191700.26532-1-luisbg@kernel.org> Date: Wed, 6 Dec 2017 19:16:58 +0000 From: Luis de Bethencourt <luisbg@...nel.org> To: linux-kernel@...r.kernel.org Cc: devel@...verdev.osuosl.org, lustre-devel@...ts.lustre.org, Lai Siyao <lai.siyao@...el.com>, Ernestas Kulik <ernestas.kulik@...il.com>, Aastha Gupta <aastha.gupta4104@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, James Simmons <jsimmons@...radead.org>, Andreas Dilger <andreas.dilger@...el.com>, Oleg Drokin <oleg.drokin@...el.com>, Luis de Bethencourt <luisbg@...nel.org> Subject: [PATCH 1/3] staging: lustre: llite: Remove else after goto If an "if" branch is terminated by a "goto", there's no need to have an "else" statement and an indented block of code. Remove the "else" statement to simplify the code flow. Signed-off-by: Luis de Bethencourt <luisbg@...nel.org> --- Hi, The following patches remove unneeded 'else' after a 'goto' or 'return'. They are meant to just make the code more readable and aren't functional changes. Thanks, Luis drivers/staging/lustre/lustre/llite/dir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c index 5b2e47c246f3..f5b67a4923e3 100644 --- a/drivers/staging/lustre/lustre/llite/dir.c +++ b/drivers/staging/lustre/lustre/llite/dir.c @@ -1339,9 +1339,9 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg) cmd == LL_IOC_MDC_GETINFO)) { rc = 0; goto skip_lmm; - } else { - goto out_req; } + + goto out_req; } if (cmd == IOC_MDC_GETFILESTRIPE || -- 2.15.1
Powered by blists - more mailing lists