lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Dec 2017 22:49:01 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Dan Murphy <dmurphy@...com>
Cc:     Tony Lindgren <tony@...mide.com>,
        linux-omap <linux-omap@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: omap2: hide omap3_save_secure_ram on non-OMAP3 builds

On Wed, Dec 6, 2017 at 5:29 PM, Dan Murphy <dmurphy@...com> wrote:
> Arnd
>
> On 12/06/2017 09:57 AM, Tony Lindgren wrote:
>> * Arnd Bergmann <arnd@...db.de> [171206 14:18]:
>>> In configurations without CONFIG_OMAP3 but with secure RAM support,
>>> we now run into a link failure:
>>>
>>> arch/arm/mach-omap2/omap-secure.o: In function `omap3_save_secure_ram':
>>> omap-secure.c:(.text+0x130): undefined reference to `save_secure_ram_context'
>>>
>>> The omap3_save_secure_ram() function is only called from the OMAP34xx
>>> power management code, so we can simply hide that function in the
>>> appropriate #ifdef.
>>>
>>> Fixes: d09220a887f7 ("ARM: OMAP2+: Fix SRAM virt to phys translation for save_secure_ram_context")
>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>>
>> Thanks for fixing it, want to apply directly to ARM SoC fixes
>> where d09220a887f7 is now? If so:
>>
>> Acked-by: Tony Lindgren <tony@...mide.com>
>
> Found the same issue in our builds.
> Compile tested the patch against different TI defconfig configurations.
>
> Tested-by: Dan Murphy <dmurphy@...com>

Thanks!

Unfortunately, I found another build problem with CONFIG_PM=n,
sent an updated patch now, and will apply it to the fixes branch
tomorrow keeping both of your Acked-by/Tested-by tags, unless
I hear any objections or run into a third problem.

       Arnd

Powered by blists - more mailing lists