linux-kernel - Re: [PATCH] ARM: omap2: hide omap3_save_secure_ram on non-OMAP3 builds

Open Source and information security mailing list archives

Date:   Wed, 6 Dec 2017 10:29:59 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Tony Lindgren <tony@...mide.com>, Arnd Bergmann <arnd@...db.de>
CC:     <linux-omap@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: omap2: hide omap3_save_secure_ram on non-OMAP3
 builds

Arnd

On 12/06/2017 09:57 AM, Tony Lindgren wrote:
> * Arnd Bergmann <arnd@...db.de> [171206 14:18]:
>> In configurations without CONFIG_OMAP3 but with secure RAM support,
>> we now run into a link failure:
>>
>> arch/arm/mach-omap2/omap-secure.o: In function `omap3_save_secure_ram':
>> omap-secure.c:(.text+0x130): undefined reference to `save_secure_ram_context'
>>
>> The omap3_save_secure_ram() function is only called from the OMAP34xx
>> power management code, so we can simply hide that function in the
>> appropriate #ifdef.
>>
>> Fixes: d09220a887f7 ("ARM: OMAP2+: Fix SRAM virt to phys translation for save_secure_ram_context")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> 
> Thanks for fixing it, want to apply directly to ARM SoC fixes
> where d09220a887f7 is now? If so:
> 
> Acked-by: Tony Lindgren <tony@...mide.com>

Found the same issue in our builds.  
Compile tested the patch against different TI defconfig configurations.

Tested-by: Dan Murphy <dmurphy@...com>

Dan

> 
> Regards,
> 
> Tony
> 
> 
>> ---
>>  arch/arm/mach-omap2/omap-secure.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c
>> index f9303dc631e4..7be95cd8136d 100644
>> --- a/arch/arm/mach-omap2/omap-secure.c
>> +++ b/arch/arm/mach-omap2/omap-secure.c
>> @@ -72,6 +72,7 @@ phys_addr_t omap_secure_ram_mempool_base(void)
>>  	return omap_secure_memblock_base;
>>  }
>>  
>> +#ifdef CONFIG_ARCH_OMAP3
>>  u32 omap3_save_secure_ram(void __iomem *addr, int size)
>>  {
>>  	u32 ret;
>> @@ -90,6 +91,7 @@ u32 omap3_save_secure_ram(void __iomem *addr, int size)
>>  
>>  	return ret;
>>  }
>> +#endif
>>  
>>  /**
>>   * rx51_secure_dispatcher: Routine to dispatch secure PPA API calls
>> -- 
>> 2.9.0
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@...ts.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
------------------
Dan Murphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives