linux-kernel - Re: [PATCH] dt: bindings: as3645a: Fix the example node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Dec 2017 16:32:36 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Rob Herring <robh@...nel.org>
CC:     <mark.rutland@....com>, <rpurdie@...ys.net>,
        <jacek.anaszewski@...il.com>, <pavel@....cz>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-leds@...r.kernel.org>
Subject: Re: [PATCH] dt: bindings: as3645a: Fix the example node

Rob

On 12/06/2017 03:52 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
>> Fix the address-cells and size-cells example node
>> to reflect to the correct representation.
>>
>> Signed-off-by: Dan Murphy <dmurphy@...com>
>> ---
>>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> index fdc40e354a64..8a49ccfec29b 100644
>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
>> @@ -59,8 +59,8 @@ Example
>>  =======
>>  
>>  	as3645a@30 {
>> -		#address-cells: 1
>> -		#size-cells: 0
>> +		#address-cells = <1>;
>> +		#size-cells = <0>;
>>  		reg = <0x30>;
>>  		compatible = "ams,as3645a";
> 
> Convention is also we put compatible first.
> 

OK I will move that too for v2.

Can that be in the same patch or do you want a separate patch?

Dan

>>  		flash@0 {
>> -- 
>> 2.15.0.124.g7668cbc60
>>


-- 
------------------
Dan Murphy