linux-kernel - Re: [PATCH 1/1] mtd: nand: brcmnand: Zero bitflip is not an error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171206101645.0576dff9@bbrezillon>
Date:   Wed, 6 Dec 2017 10:16:45 +0100
From:   Boris Brezillon <boris.brezillon@...e-electrons.com>
To:     Albert Hsieh <wen.hsieh@...adcom.com>, richard@....at
Cc:     computersforpeace@...il.com, hsiehwt@...il.com,
        kdasu.kdev@...il.com, linux-kernel@...r.kernel.org,
        marek.vasut@...il.com, linux-mtd@...ts.infradead.org,
        cyrille.pitchen@...ev4u.fr, bcm-kernel-feedback-list@...adcom.com,
        dwmw2@...radead.org
Subject: Re: [PATCH 1/1] mtd: nand: brcmnand: Zero bitflip is not an error

On Mon, 20 Nov 2017 11:26:26 +0800
Albert Hsieh <wen.hsieh@...adcom.com> wrote:

> A negative return value of brcmstb_nand_verify_erased_page() indicates a
> real bitflip error of an erased page, and other return values (>= 0) show
> the corrected bitflip number. Zero return value means no bitflip, but the
> current driver code treats it as an error, and eventually leads to
> falsely reported ECC error.
> 
> Fixes: 02b88eea9f9c ("mtd: brcmnand: Add check for erased page bitflip")
> Signed-off-by: Albert Hsieh <wen.hsieh@...adcom.com>

Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc: <stable@...r.kernel.org>

Richard, can you queue this patch to the mtd/master branch?

Thanks,

Boris

> ---
>  drivers/mtd/nand/brcmnand/brcmnand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> index e0eb51d..dd56a67 100644
> --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> @@ -1763,7 +1763,7 @@ static int brcmnand_read(struct mtd_info *mtd, struct nand_chip *chip,
>  			err = brcmstb_nand_verify_erased_page(mtd, chip, buf,
>  							      addr);
>  			/* erased page bitflips corrected */
> -			if (err > 0)
> +			if (err >= 0)
>  				return err;
>  		}
>