linux-kernel - Re: [PATCH v2] pata_pdc2027x: Fix coding sytle errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a37d055-8ded-a8d3-8af8-b58f58726849@cogentembedded.com>
Date:   Wed, 6 Dec 2017 12:43:14 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, b.zolnierkie@...sung.com,
        tj@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH v2] pata_pdc2027x: Fix coding sytle errors

On 12/5/2017 9:26 PM, Arvind Yadav wrote:

> Fix these checkpatch.pl errors:
> Fix checkpatch.pl error:

    Why repeat it twice?

> ERROR: space prohibited before open square bracket '['.
> 
> ERROR: space prohibited after that '~' (ctx:WxW)
> +		mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
> 
> ERROR: spaces required around that '?' (ctx:VxW)
> +	long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
> 
> ERROR: that open brace { should be on the previous line
> +	const struct ata_port_info *ppi[] =
> +		{ &pdc2027x_port_info[board_idx], NULL };
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
> changes in v2:
>               Subject and description was not correct.
>               *s/sytle error/style errors/ in the patch summary

    You didn't really fix the subject. :-/

[...]

MBR, Sergei