linux-kernel - [tip:x86/urgent] x86/PCI: Make broadcom_postcore_init() check acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-ddec3bdee05b06f1dda20ded003c3e10e4184cab@git.kernel.org>
Date:   Wed, 6 Dec 2017 03:35:44 -0800
From:   "tip-bot for Rafael J. Wysocki" <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, dave.hansen@...ux.intel.com,
        linux-pci@...r.kernel.org, rafael.j.wysocki@...el.com,
        mingo@...nel.org, hpa@...or.com, bhelgaas@...gle.com,
        tglx@...utronix.de
Subject: [tip:x86/urgent] x86/PCI: Make broadcom_postcore_init() check
 acpi_disabled

Commit-ID:  ddec3bdee05b06f1dda20ded003c3e10e4184cab
Gitweb:     https://git.kernel.org/tip/ddec3bdee05b06f1dda20ded003c3e10e4184cab
Author:     Rafael J. Wysocki <rafael.j.wysocki@...el.com>
AuthorDate: Fri, 1 Dec 2017 15:08:12 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 6 Dec 2017 12:27:47 +0100

x86/PCI: Make broadcom_postcore_init() check acpi_disabled

acpi_os_get_root_pointer() may return a valid address even if acpi_disabled
is set, but the host bridge information from the ACPI tables is not going
to be used in that case and the Broadcom host bridge initialization should
not be skipped then, So make broadcom_postcore_init() check acpi_disabled
too to avoid this issue.

Fixes: 6361d72b04d1 (x86/PCI: read Broadcom CNB20LE host bridge info before PCI scan)
Reported-by: Dave Hansen <dave.hansen@...ux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Linux PCI <linux-pci@...r.kernel.org>
Cc: stable@...r.kernel.org
Link: https://lkml.kernel.org/r/3186627.pxZj1QbYNg@aspire.rjw.lan
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/pci/broadcom_bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/pci/broadcom_bus.c b/arch/x86/pci/broadcom_bus.c
index bb461cf..526536c 100644
--- a/arch/x86/pci/broadcom_bus.c
+++ b/arch/x86/pci/broadcom_bus.c
@@ -97,7 +97,7 @@ static int __init broadcom_postcore_init(void)
 	 * We should get host bridge information from ACPI unless the BIOS
 	 * doesn't support it.
 	 */
-	if (acpi_os_get_root_pointer())
+	if (!acpi_disabled && acpi_os_get_root_pointer())
 		return 0;
 #endif