linux-kernel - [tip:x86/urgent] x86 / PCI: Make broadcom_postcore_init() check acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-2ee90363a838cf41ebf1ad24bad274762e467d8d@git.kernel.org>
Date:   Mon, 4 Dec 2017 14:24:44 -0800
From:   "tip-bot for Rafael J. Wysocki" <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     rafael.j.wysocki@...el.com, tglx@...utronix.de,
        bhelgaas@...gle.com, hpa@...or.com, mingo@...nel.org,
        linux-pci@...r.kernel.org, dave.hansen@...ux.intel.com,
        linux-kernel@...r.kernel.org
Subject: [tip:x86/urgent] x86 / PCI: Make broadcom_postcore_init() check
 acpi_disabled

Commit-ID:  2ee90363a838cf41ebf1ad24bad274762e467d8d
Gitweb:     https://git.kernel.org/tip/2ee90363a838cf41ebf1ad24bad274762e467d8d
Author:     Rafael J. Wysocki <rafael.j.wysocki@...el.com>
AuthorDate: Fri, 1 Dec 2017 15:08:12 +0100
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Mon, 4 Dec 2017 23:20:35 +0100

x86 / PCI: Make broadcom_postcore_init() check acpi_disabled

acpi_os_get_root_pointer() may return a valid address even if acpi_disabled
is set, but the host bridge information from the ACPI tables is not going
to be used in that case and the Broadcom host bridge initialization should
not be skipped then, So make broadcom_postcore_init() check acpi_disabled
too to avoid this issue.

Fixes: 6361d72b04d1 (x86/PCI: read Broadcom CNB20LE host bridge info before PCI scan)
Reported-by: Dave Hansen <dave.hansen@...ux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>
Cc: Linux PCI <linux-pci@...r.kernel.org>
Cc: stable@...r.kernel.org
Link: https://lkml.kernel.org/r/3186627.pxZj1QbYNg@aspire.rjw.lan
---
 arch/x86/pci/broadcom_bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/pci/broadcom_bus.c b/arch/x86/pci/broadcom_bus.c
index bb461cf..526536c 100644
--- a/arch/x86/pci/broadcom_bus.c
+++ b/arch/x86/pci/broadcom_bus.c
@@ -97,7 +97,7 @@ static int __init broadcom_postcore_init(void)
 	 * We should get host bridge information from ACPI unless the BIOS
 	 * doesn't support it.
 	 */
-	if (acpi_os_get_root_pointer())
+	if (!acpi_disabled && acpi_os_get_root_pointer())
 		return 0;
 #endif