linux-kernel - Re: Checkpatch ignores spelling error by using -f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.20.1712061600020.6620@5HSWXM1.fritz.box>
Date:   Wed, 6 Dec 2017 16:01:55 +0100 (CET)
From:   Rolf Evers-Fischer <embedded24@...rs-fischer.de>
To:     Joe Perches <joe@...ches.com>
cc:     Rolf Evers-Fischer <embedded24@...rs-fischer.de>,
        apw@...onical.com, linux-kernel@...r.kernel.org
Subject: Re: Checkpatch ignores spelling error by using -f



On Wed, 6 Dec 2017, Joe Perches wrote:

> On Wed, 2017-12-06 at 15:13 +0100, Rolf Evers-Fischer wrote:
> > Hello,
> > I've just checked the file drivers/tty/serial/8250/8250_omap.c, using 
> > checkpatch.pl, but I forgot the '-f' option (for file).
> > 
> > Surprisingly the checkpatch script reported a misspelling:
> > 
> > "WARNING: 'additionaly' may be misspelled - perhaps 'additionally'?
> > #417: 
> >          * We enable TRIG_GRANU for RX and TX and additionaly we set"
> > 
> > Additionally it reported that the file does not appear to be a 
> > unified-diff (due to my mistake).
> > 
> > Running checkpatch again with '-f', it didn't report any problems:
> > 
> > "drivers/tty/serial/8250/8250_omap.c has no obvious style problems and is 
> > ready for submission."
> > 
> > Is this a bug in checkpatch.pl? Or is it a feature?
> 
> feature.  kinda.
> 
> checkpatch reports spelling errors in commit messages.
> 
> Without the -f, checkpatch is reading its input as a
> commit message before expecting to find a diff/patch.
> 
> 
> 
> 

Thank you very much for this explanation.

Best regards,
 Rolf