lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Dec 2017 17:43:44 +0100
From:   Ingo Molnar <>
To:     Linus Torvalds <>
Cc:     Omar Sandoval <>,
        Linux Kernel Mailing List <>,
        Jens Axboe <>
Subject: Re: add_wait_queue() (unintentional?) behavior change in v4.13

* Linus Torvalds <> wrote:

> On Wed, Nov 29, 2017 at 4:58 PM, Omar Sandoval <> wrote:
> >
> > Note the change from __add_wait_queue() to
> > __add_wait_queue_entry_tail(). I'm assuming this was a typo since the
> > commit message doesn't mention any functional changes. This patch
> > restores the old behavior:
> >   [...]
> > I didn't go through and audit callers of add_wait_queue(), but from a
> > quick code read this makes it so that non-exclusive waiters will not be
> > woken up if they are behind enough exclusive waiters, and I bet that'll
> > cause some bugs.
> This sounds right to me.
> Ingo?

Yeah, it's indeed unintended and it's a bug - I have applied the fix and will get 
it to you ASAP.



Powered by blists - more mailing lists