lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Dec 2017 17:46:09 +0100
From:   Ingo Molnar <>
To:     Jens Axboe <>
Cc:     Omar Sandoval <>,,
        Linus Torvalds <>,
        Ingo Molnar <>,
        Peter Zijlstra <>,
Subject: Re: [PATCH] sched/wait: fix add_wait_queue() behavior change

* Jens Axboe <> wrote:

> On 12/06/2017 12:15 AM, Omar Sandoval wrote:
> > From: Omar Sandoval <>
> > 
> > Commit 50816c48997a ("sched/wait: Standardize internal naming of
> > wait-queue entries") changed the behavior of add_wait_queue() from
> > inserting the wait entry at the head of the wait queue to the tail of
> > the wait queue. That commit was a cleanup and didn't mention any
> > functional changes so it was likely unintentional. This change in
> > behavior theoretically breaks wait queues which mix exclusive and
> > non-exclusive waiters, as non-exclusive waiters will not be woken up if
> > they are queued behind enough exclusive waiters.
> Ingo? You've been silent on this issue, which is somewhat odd since
> your cosmetic renaming patch introduced this behavioral change.
> Omar, should probably turn that into a proper Fixes: line as
> well.
> > Signed-off-by: Omar Sandoval <>
> Reviewed-by: Jens Axboe <>


I've applied the fix and will send it to Linus later today.



Powered by blists - more mailing lists