linux-kernel - Re: [PATCH] USB: hub: Delete an error message for a failed memory allocation in usb_hub_clear_tt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Dec 2017 18:27:23 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        USB list <linux-usb@...r.kernel.org>,
        Daniel Drake <drake@...lessm.com>,
        Dmitry Fleytman <dmitry@...nix.com>,
        Eugene Korenevsky <ekorenevsky@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Günter Röck <linux@...ck-us.net>,
        Johan Hovold <johan@...nel.org>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Peter Chen <peter.chen@....com>,
        LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] USB: hub: Delete an error message for a failed memory
 allocation in usb_hub_clear_tt_buffer()

Hi Alan,

On Wed, Dec 6, 2017 at 5:45 PM, Alan Stern <stern@...land.harvard.edu> wrote:
> On Wed, 6 Dec 2017, SF Markus Elfring wrote:
>
>> From: Markus Elfring <elfring@...rs.sourceforge.net>
>> Date: Wed, 6 Dec 2017 17:00:18 +0100
>>
>> Omit an extra message for a memory allocation failure in this function.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
>> ---
>>  drivers/usb/core/hub.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
>> index 7ccdd3d4db84..9fbb908e9552 100644
>> --- a/drivers/usb/core/hub.c
>> +++ b/drivers/usb/core/hub.c
>> @@ -829,7 +829,6 @@ int usb_hub_clear_tt_buffer(struct urb *urb)
>>        */
>>       clear = kmalloc(sizeof *clear, GFP_ATOMIC);
>>       if (clear == NULL) {
>> -             dev_err(&udev->dev, "can't save CLEAR_TT_BUFFER state\n");
>>               /* FIXME recover somehow ... RESET_TT? */
>>               return -ENOMEM;
>>       }
>
> Does the existing memory allocation error message include the
> &udev->dev device name and driver name?  If it doesn't, there will be
> no way for the user to tell that the error message is related to the
> device failure.

The system will come to a grinding halt anyway if it can't allocate 24 or 40
bytes. Which is BTW more or less the amount of memory saved by killing
the useless (error) message.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds